Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRRDLoader: Make sure scan() always returns a typed array. #27212

Merged
merged 1 commit into from
Nov 19, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions examples/jsm/loaders/NRRDLoader.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,6 @@ class NRRDLoader extends Loader {

function scan( type, chunks ) {

if ( chunks === undefined || chunks === null ) {

chunks = 1;

}

let _chunkSize = 1;
let _array_type = Uint8Array;

Expand Down Expand Up @@ -138,13 +132,6 @@ class NRRDLoader extends Loader {

}

if ( chunks == 1 ) {

// if only one chunk was requested, just return one value
return _bytes[ 0 ];

}

// return the byte array
return _bytes;

Expand Down