Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ViewHelper: Make label text and style configurable. #28688

Merged
merged 6 commits into from
Jun 21, 2024
Merged

ViewHelper: Make label text and style configurable. #28688

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
89a772b
ViewHelper: Add options to the constructor
puxiao Jun 18, 2024
7cae6e2
Update ViewHelper.js
Mugen87 Jun 18, 2024
82ca339
add setLabels, setLabelStyle
puxiao Jun 19, 2024
3917dfa
add setLabels, setLabelStyle
puxiao Jun 19, 2024
115085e
update
puxiao Jun 19, 2024
5b45dad
Update ViewHelper.js
Mugen87 Jun 20, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@puxiao
puxiao committed Jun 19, 2024
commit 115085e4b5d9dd5a99219ccd627daa33ce38d117
2 changes: 1 addition & 1 deletion examples/jsm/helpers/ViewHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ class ViewHelper extends Object3D {

function getSpriteMaterial( color, text ) {

const { font = '24px Arial', labelColor = '#000000', radius = 14 } = options;
const { font = '24px Arial', color: labelColor = '#000000', radius = 14 } = options;

const canvas = document.createElement( 'canvas' );
canvas.width = 64;
Expand Down