Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSL: BatchNode - Fix BiasNode conflict #28792

Merged
merged 2 commits into from
Jul 3, 2024
Merged

TSL: BatchNode - Fix BiasNode conflict #28792

merged 2 commits into from
Jul 3, 2024

Conversation

RenaudRohlinger
Copy link
Collaborator

Related issue: #28779

Description

Cleanup BatchNode that has a 4th parameter that was conflicting with the new biasNode. This fixes the webgpu_mesh_batch example too.

This contribution is funded by Utsubo
@RenaudRohlinger RenaudRohlinger added the TSL Three.js Shading Language label Jul 3, 2024
@RenaudRohlinger RenaudRohlinger merged commit 312f9c7 into mrdoob:dev Jul 3, 2024
10 of 11 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
682.2 kB (169 kB) 682.2 kB (169 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
459.4 kB (110.9 kB) 459.4 kB (110.9 kB) +0 B
@Mugen87 Mugen87 added this to the r167 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TSL Three.js Shading Language
2 participants
@RenaudRohlinger @Mugen87