Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextureNode: Rename _matrixValue to _matrixUniform #28809

Merged
merged 1 commit into from
Jul 4, 2024
Merged

TextureNode: Rename _matrixValue to _matrixUniform #28809

merged 1 commit into from
Jul 4, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 4, 2024

Related issue: #28801

Description

Improve property name.
@sunag sunag marked this pull request as ready for review July 4, 2024 18:13
@sunag sunag added this to the r167 milestone Jul 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
683.5 kB (169.2 kB) 683.5 kB (169.2 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.6 kB (111.1 kB) 460.6 kB (111.1 kB) +0 B
@sunag sunag merged commit 4210ee8 into mrdoob:dev Jul 4, 2024
12 checks passed
@sunag sunag changed the title TextureNode: Rename _matrixValue to _matrixUniform Jul 4, 2024
@sunag sunag deleted the dev-names branch July 4, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@sunag