Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes: Add missing dispose() methods. #28892

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Nodes: Add missing dispose() methods. #28892

merged 1 commit into from
Jul 16, 2024

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 16, 2024

Related issue: -

Description

This PR adds some missing dispose() methods in effects classes to free internal render targets.
@Mugen87 Mugen87 added this to the r167 milestone Jul 16, 2024
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
683.5 kB (169.2 kB) 683.5 kB (169.2 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.7 kB (111.1 kB) 460.7 kB (111.1 kB) +0 B
@Mugen87 Mugen87 merged commit 7a91d80 into mrdoob:dev Jul 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@Mugen87