KTX2Loader: Add parse() method for direct buffer processing.
#28936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
approved these changes
Jul 25, 2024
Mugen87
changed the title
|
Thank you @laddish! |
brunosimon
pushed a commit
to brunosimon/three.js
that referenced
this pull request
Jul 25, 2024
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a parse method to the KTX2Loader class, allowing for direct buffer processing. Previously, the load method was responsible for loading and processing the buffer. By introducing the parse method, we enhance modularity and provide a way to directly handle buffer parsing, which is useful for cases where the buffer is already available and doesn't need to be loaded from a URL.
Changes made:
Added a parse method to handle buffer processing and texture creation.
Refactored the load method to call the parse method with the buffer.
This change resolves the need to directly parse buffers in scenarios where using the KTX2Loader is necessary, improving flexibility and usability in various applications.