Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeMaterial: Add setupOutgoingLight(). #28941

Merged
merged 5 commits into from
Jul 23, 2024
Merged

NodeMaterial: Add setupOutgoingLight(). #28941

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a1aa97
NodeMaterial: Add `setupOutgoingLight()`.
Mugen87 Jul 23, 2024
d4fc872
NodeMaterial: Set `lights` to `false` by default.
Mugen87 Jul 23, 2024
856bdb8
Examples: Fix lighting.
Mugen87 Jul 23, 2024
c98d770
E2E: Update screenshots.
Mugen87 Jul 23, 2024
8008ea2
add builder as parameter for optional usage
sunag Jul 23, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add builder as parameter for optional usage
  • Loading branch information
@sunag
sunag committed Jul 23, 2024
commit 8008ea2001aba62eb72822d5943323b6af25a6d9
2 changes: 1 addition & 1 deletion src/nodes/materials/NodeMaterial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ class NodeMaterial extends Material {

const lightsNode = lights ? this.setupLights( builder ) : null;

let outgoingLightNode = this.setupOutgoingLight();
let outgoingLightNode = this.setupOutgoingLight( builder );

if ( lightsNode && lightsNode.hasLight !== false ) {

Expand Down