Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSL: Remove stack parameter of Fn() #29070

Merged
merged 1 commit into from
Aug 6, 2024
Merged

TSL: Remove stack parameter of Fn() #29070

merged 1 commit into from
Aug 6, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 6, 2024

Description

After several improvements in flow control through direct functions, I think we can remove stack as a parameter since it has fallen into disuse.
@sunag sunag changed the title TSL: Remove stack parameter Aug 6, 2024
@sunag sunag added this to the r168 milestone Aug 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.1 kB (169.6 kB) 685.1 kB (169.6 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.5 kB) 462 kB (111.5 kB) +0 B
@sunag sunag marked this pull request as ready for review August 6, 2024 01:14
@sunag sunag changed the title TSL: Remove stack parameter in Fn() Aug 6, 2024
@sunag sunag merged commit b3d39ff into mrdoob:dev Aug 6, 2024
12 checks passed
@sunag sunag deleted the dev-stack-remove branch August 6, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@sunag