Nodes: Add CubeMapNode.
#29073
Nodes: Add CubeMapNode.
#29073
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
|
||
| const _cache = new WeakMap(); | ||
|
|
||
| class CubeMapNode extends TempNode { |
There was a problem hiding this comment.
@sunag This module should be for internal use only so it is not exported in Nodes.js. Still, I'm a bit unsure about the name CubeMapNode since its quite similar to CubeTextureNode.
CubeMapNode should be in some sense the non-PBR version of PMREMNode. Meaning it encapsulate different inputs to provide a single environment map format for the material.
There was a problem hiding this comment.
I'm not sure if we need this, wouldn't just manipulating the UV be enough since we don't need to pre-filter for non-PBR?
import { texture, equirectUV, reflectVector, refractVector } from 'three/ts';
const coord = reflectVector; // refractVector
const env = texture( textureEquirec, equirectUV( coord ) );There was a problem hiding this comment.
The problem with using equirectangular uvs are the artifacts that result at the poles which do not occur with the cube map format. They were previously reported as bugs which was one reason for not directly supporting equirectangular textures in the shader.
I'm afraid users will complain when the artifacts appear again when migrating from WebGLRenderer.
There was a problem hiding this comment.
Interesting, if so let's merge the PR, it seems good to me.
Related issue: -
Description
WebGPURenderermust be able to automatically convert equirectangular textures into the cube map format. This is now done by a new utility classCubeMapNode. Similar toPMREMNode, this class is intended to setup the environment map for materials and later the background (see #28827).