ToneMappingNode: properly handle alpha #29076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
commented
Aug 7, 2024
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
![github-advanced-security[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WestLangley
commented
Aug 7, 2024
WestLangley
commented
Aug 7, 2024
WestLangley
force-pushed
the
dev-webgpu_tone_mapping
branch
from
d8994d2
to
138a89c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For WebGLRenderer, the input to the tone mapping function is
vec3 color.However, for WebGPURenderer, the input is
vec4 color. (And, since it is implemented as a post processing step, the RGB components have premultiplied alpha -- but that is not an issue here.)The tone mapping operation and color space transform should be applied to the RGB channels only. The alpha channel should remain unchanged.