Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodes: Remove keywords #29129

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Nodes: Remove keywords #29129

merged 1 commit into from
Aug 14, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 14, 2024

Description

Keyword should replace variables in GLSL/WGSL with node names, after TSL this became unnecessary and was in disuse for a long time.
@sunag sunag added this to the r168 milestone Aug 14, 2024
@github-actions GitHub Actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.1 kB (169.6 kB) 685.1 kB (169.6 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B
@sunag sunag marked this pull request as ready for review August 14, 2024 02:47
@sunag sunag merged commit 828769f into mrdoob:dev Aug 14, 2024
12 checks passed
@sunag sunag deleted the dev-keywords branch August 14, 2024 03:23
This was referenced Aug 25, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@sunag