Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed LogLuvLoader #29144

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Removed LogLuvLoader #29144

merged 2 commits into from
Aug 27, 2024

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Aug 15, 2024

Related: #29143

@Mugen87 Now that we have UltraHDR, I think we can remove this loader?

@mrdoob mrdoob added this to the r168 milestone Aug 15, 2024
@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 15, 2024

Are you planning to remove RGBMLoader as well?

If so, is it possible to convert RGBM or LogLuv HDR textures to UltraHDR somehow? The thing is if we remove those loaders, it's not possible to import such HDR textures into three.js anymore (unless apps maintain the loaders for themselves).

On the other hand RGBM or LogLuv are quite special and I'm not sure we need to maintain them in this repository. If there is a need for importers, they can be maintained by other community members in third-party repositories.

@WestLangley
Copy link
Collaborator

Are you planning to remove RGBMLoader as well?

Also, is the plan to rename RGBELoader to HDRLoader -- for loading Radiance .hdr files -- or to remove RGBELoader, too?

@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 15, 2024

IMO, we should not remove RGBELoader.

If we follow that logic, we could apply it in context of 3D assets as well and basically remove almost every loader except for GLTFLoader.

Repository owner deleted a comment from sommaichaisit Aug 25, 2024
@mrdoob
Copy link
Owner Author

mrdoob commented Aug 27, 2024

@WestLangley

Also, is the plan to rename RGBELoader to HDRLoader -- for loading Radiance .hdr files -- or to remove RGBELoader, too?

Renaming RGBELoader to HDRLoader sounds good to me.

@mrdoob
Copy link
Owner Author

mrdoob commented Aug 27, 2024

@Mugen87

Are you planning to remove RGBMLoader as well?

Probably too?

@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 27, 2024

Okay, I'm fine with the removal of both loaders.

I suspect they are only sporadically used because of their exotic character so there should not be that much of complains. With UltraHDR, there is now a better alternative as well.

@mrdoob mrdoob merged commit 305ad18 into dev Aug 27, 2024
11 checks passed
@mrdoob mrdoob deleted the logluv branch August 27, 2024 11:00
daniele-pelagatti added a commit to MONOGRID/gainmap-js that referenced this pull request Sep 3, 2024
daniele-pelagatti added a commit to MONOGRID/gainmap-js that referenced this pull request Sep 3, 2024
daniele-pelagatti pushed a commit to MONOGRID/gainmap-js that referenced this pull request Sep 3, 2024
## [3.0.6](v3.0.5...v3.0.6) (2024-09-03)

### Bug Fixes

* remove LogLuv following threejs removal mrdoob/three.js#29144 ([1df2154](1df2154))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants