Examples: Remove curvature estimation demo. #29171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I vote for removing it too 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: -
Description
We should revisit some
webgl_*examples and decide whether or not the code should be migrated toWebGPURendereror maybe removed altogether. We can do this in a case-by-case manner.One demo that I like to suggest to remove is
webgl_materials_curvature. It is focused on a very specific topic (curvature estimation) and I suspect it is not clear for most users looking at the demo what it is actually showcasing. Since it also has a dependency toShaderMaterial, I vote to remove it.