Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSL: Rename viewportTopLeft -> viewportUV #29211

Merged
merged 2 commits into from
Aug 22, 2024
Merged

TSL: Rename viewportTopLeft -> viewportUV #29211

merged 2 commits into from
Aug 22, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 22, 2024

Related issue: #29162 (comment), #29162 (comment)

Description

  • Renaming viewportTopLeft to viewportUV.
  • Drop z-coordinate of viewportCoordinate
  • Remove viewport + top/bottom-left/right
@sunag sunag added this to the r168 milestone Aug 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B
@sunag sunag marked this pull request as ready for review August 22, 2024 18:43
@sunag sunag merged commit f22b8b0 into mrdoob:dev Aug 22, 2024
12 checks passed
@sunag sunag deleted the dev-viewport-2 branch August 22, 2024 18:43
@RenaudRohlinger RenaudRohlinger mentioned this pull request Aug 24, 2024
Merged
This was referenced Aug 25, 2024
Merged
Closed
@sunag sunag mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@sunag