Automate version resolution #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbostock
force-pushed
the
mbostock/resolve-dependencies
branch
2 times, most recently
from
c30afb5
to
2e62dd9
Compare
|
Gentle ping on the review, @visnup? |
visnup
approved these changes
Jul 3, 2021
There was a problem hiding this comment.
Do you need yarn to actually do work given the version or are you just looking for a convenient place to list package names and versions? I think npm and yarn are neutral when it comes to additional package.json keys and values that aren't standard so it could be possible to list the dependencies in there under a custom key... that's probably not buying us much though?
mbostock
force-pushed
the
mbostock/resolve-dependencies
branch
from
2e62dd9
to
386fcb7
Compare
mbostock
force-pushed
the
mbostock/resolve-dependencies
branch
from
386fcb7
to
72ee81a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make it easier to keep these versions up-to-date, and to avoid hard-coding the versions in multiple places. I couldn’t figure out a good way to track the versions using yarn (I considered devDependencies), but this at least gives us a script we can run to refresh the dependency versions and then see if we want to update.