Fix setup.py import of versioneer w/ PEP 517 #3757
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same issue as dandi/dandi-cli#998. If versioneer is installed on the system, by appending our copy to the import path, we're going to end up colliding and mixing-and-matching. We always want to use the local copy vendored in tree. Bug: https://bugs.gentoo.org/841002 Signed-off-by: Sam James <sam@gentoo.org>
|
The CI failure is unrelated. |
|
Hi there! Sorry this is so late, I'm sweeping through long-opened PRs... Can you please expand a little bit on how this change solves the problem you're seeing? I'm not sure I understand... Thanks! |
|
Hi, honestly, I'd completely forgot about this. I think versioneer was installed on the system but the copy inside plotly.py was importing a mixture of the one in the source directory and the system one. It's the same thing as at dandi/dandi-cli#998 (comment) -- I think it shows up more if the versions are pretty diverged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same issue as dandi/dandi-cli#998.
If versioneer is installed on the system, by appending our copy
to the import path, we're going to end up colliding and mixing-and-matching.
We always want to use the local copy vendored in tree.
Bug: https://bugs.gentoo.org/841002
Signed-off-by: Sam James sam@gentoo.org
Code PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.