-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix comment creation button state toggle #10019
Conversation
Made appropriate changes in the file. Please review it
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
Code Climate has analyzed commit 1992875 and detected 0 issues on this pull request. View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## main #10019 +/- ##
==========================================
- Coverage 82.13% 82.06% -0.08%
==========================================
Files 98 98
Lines 5968 5976 +8
==========================================
+ Hits 4902 4904 +2
- Misses 1066 1072 +6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @aummishra LGTM 🎉 Welcome to Publiclab 🎈 Thanks for contributing ✌️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, awesome! Would you be able to edit the title to be a bit more descriptive of the purpose and context, so when we see it in our Pulse view, it's more clear, in a list? Thank you!!!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
Made appropriate changes in the file. Please review it
Made appropriate changes in the file. Please review it
Made appropriate changes in the file. Please review it
Fixes #10000
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below