Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comment creation button state toggle #10019

Merged
merged 1 commit into from
Aug 14, 2021
Merged

Conversation

aummishra
Copy link
Contributor

Made appropriate changes in the file. Please review it

Fixes #10000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below
Made appropriate changes in the file. Please review it
@aummishra aummishra requested a review from a team as a code owner August 11, 2021 22:13
@welcome
Copy link

welcome bot commented Aug 11, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄

@gitpod-io
Copy link

gitpod-io bot commented Aug 11, 2021

@codeclimate
Copy link

codeclimate bot commented Aug 11, 2021

Code Climate has analyzed commit 1992875 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #10019 (1992875) into main (f41f8e7) will decrease coverage by 0.07%.
The diff coverage is 82.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10019      +/-   ##
==========================================
- Coverage   82.13%   82.06%   -0.08%     
==========================================
  Files          98       98              
  Lines        5968     5976       +8     
==========================================
+ Hits         4902     4904       +2     
- Misses       1066     1072       +6     
Impacted Files Coverage Δ
app/models/tag.rb 93.26% <44.44%> (-4.27%) ⬇️
app/controllers/images_controller.rb 70.27% <100.00%> (ø)
app/controllers/notes_controller.rb 85.09% <100.00%> (+0.22%) ⬆️
app/controllers/tag_controller.rb 80.42% <100.00%> (ø)
app/helpers/application_helper.rb 87.62% <100.00%> (+2.21%) ⬆️
app/services/search_service.rb 95.00% <100.00%> (-0.10%) ⬇️
app/controllers/user_tags_controller.rb 83.78% <0.00%> (+1.35%) ⬆️
Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @aummishra LGTM 🎉 Welcome to Publiclab 🎈 Thanks for contributing ✌️

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, awesome! Would you be able to edit the title to be a bit more descriptive of the purpose and context, so when we see it in our Pulse view, it's more clear, in a list? Thank you!!!

https://github.com/publiclab/plots2/pulse

@jywarren jywarren merged commit ac96f88 into publiclab:main Aug 14, 2021
@welcome
Copy link

welcome bot commented Aug 14, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@noi5e noi5e mentioned this pull request Aug 16, 2021
5 tasks
@jywarren jywarren changed the title Update create.js.erb Aug 31, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
Made appropriate changes in the file. Please review it
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Made appropriate changes in the file. Please review it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants