Fixed bug in advanced tagging menu #9726
Conversation
|
|
|
I've done |
Codecov Report
@@ Coverage Diff @@
## main #9726 +/- ##
=======================================
Coverage ? 82.10%
=======================================
Files ? 98
Lines ? 5928
Branches ? 0
=======================================
Hits ? 4867
Misses ? 1061
Partials ? 0 |
| <a class="dropdown-item" href="#" data-value="parent:">Link to a "parent" page (wikis only)</a> | ||
| <a class="dropdown-item" href="#" data-value="style:">Add style</a> | ||
| <a class="dropdown-item" href="#" data-value="lang:">Add Translation widget</a> | ||
| <a class="dropdown-item" href="javascript:window.location.reload(true)" data-value="parent:">Link to a "parent" page (wikis only)</a> |
There was a problem hiding this comment.
I think this may not work in Firefox, which is a little stricter on href javascript. You could put it in an onclick attribute, maybe?
| @@ -29,7 +29,7 @@ | |||
|
|
|||
| $(document).ready(function(){ | |||
|
|
|||
| $( "#pt-list > li " ).each(function() { | |||
There was a problem hiding this comment.
ah cool, i see!
OK so i think you can actually add the reload within the function below then? to avoid the href usage... does that work? Thanks!
|
Code Climate has analyzed commit 5fe5bcb and detected 0 issues on this pull request. View more on Code Climate. |
|
@jywarren I use Firefox and it works fine on my browser. But I'm adding it within the function to make the code less redundant! |
|
Great work!!!! |
* fixed bug in advanced menu * removed reload from href
* fixed bug in advanced menu * removed reload from href
Fixes #9724 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!