Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTO Changes #9745

Merged
merged 1 commit into from
Jun 9, 2021
Merged

FTO Changes #9745

merged 1 commit into from
Jun 9, 2021

Conversation

KarAyushman
Copy link
Contributor

The required correction has been made. Please approve the PR, thanks!

Fixes #9740 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [ ✔️] PR is descriptively titled 📑 and links the original issue above 🔗
  • [✔️ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [✔️ ] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [✔️ ] screenshots/GIFs are attached 📎 in case of UI updation
  • [✔️ ] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!
@KarAyushman
FTO Changes
1929c0d 
The required correction has been made. Please approve the PR, thanks!
@welcome
Copy link

welcome bot commented Jun 5, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
@gitpod-io
Copy link

gitpod-io bot commented Jun 5, 2021

codeclimate[bot]
codeclimate bot reviewed Jun 5, 2021
View reviewed changes
app/channels/room_channel.rb
@@ -9,7 +9,7 @@ def unsubscribed
end

def speak(message)
return unless current_user && current_user.role == "admin"
return unless current_user && current_user.admin?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use safe navigation (&.) instead of checking if an object exists before calling the method.
@codeclimate
Copy link

codeclimate bot commented Jun 5, 2021

Code Climate has analyzed commit 1929c0d and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Style 1

View more on Code Climate.
@codecov
Copy link

codecov bot commented Jun 5, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@4a5e5a4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9745   +/-   ##
=======================================
  Coverage        ?   82.06%           
=======================================
  Files           ?       98           
  Lines           ?     5932           
  Branches        ?        0           
=======================================
  Hits            ?     4868           
  Misses          ?     1064           
  Partials        ?        0
@Manasa2850 Manasa2850 closed this Jun 5, 2021
@Manasa2850 Manasa2850 reopened this Jun 5, 2021
@Manasa2850 Manasa2850 closed this Jun 6, 2021
@Manasa2850 Manasa2850 reopened this Jun 6, 2021
@Manasa2850 Manasa2850 closed this Jun 9, 2021
@Manasa2850 Manasa2850 reopened this Jun 9, 2021
@Manasa2850
Copy link
Member

LGTM! 🎉 💯
I think we can ignore Codeclimate for this one.
@cesswairimu
Copy link
Collaborator

I agree @Manasa2850 thanks 🎉 🎉

thanks @KarAyushman for working on this 🎉 🎉
@cesswairimu
Copy link
Collaborator

I will open a follow up fto for the code climate fix. Merging now
@cesswairimu cesswairimu merged commit f8f5f1d into publiclab:main Jun 9, 2021
@welcome
Copy link

welcome bot commented Jun 9, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.
@cesswairimu
Copy link
Collaborator

something to note @KarAyushman please be descriptive on commits/pull requests titles in future(have them explain the fix you are making). Thanks again
@KarAyushman KarAyushman deleted the patch-1 branch June 9, 2021 07:37
@KarAyushman
Copy link
Contributor Author

@Manasa2850 @cesswairimu Thank you for helping me out with the FTO Issue :)

@cesswairimu I'll keep that in mind henceforth, thanks

Thank you so much, y'all have been great!!
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
@KarAyushman @reginaalyssa
refactor admin check on channels (publiclab#9745)
cb4bd48 
The required correction has been made. Please approve the PR, thanks!
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
@KarAyushman @billymoroney1
refactor admin check on channels (publiclab#9745)
00d3a9a 
The required correction has been made. Please approve the PR, thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@KarAyushman @Manasa2850 @cesswairimu