Chords and Mensuration Sign's Orientation and Loc #3790
Merged
+86
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpugin
reviewed
Sep 19, 2024
| { | ||
| assert(m_currentContainer); | ||
|
|
||
| Chord *chord = new Chord(); |
There was a problem hiding this comment.
What about the chord duration? I guess in CMME it is given in the notes (each of them). The practice in Verovio is to expect the longest duration to be given in the chord
There was a problem hiding this comment.
I think my latest commit does this, but please check
lpugin
reviewed
Sep 19, 2024
|
Merging now, will be adjusted if needed. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for translating the orientation of mensuration signs from CMME to MEI. Also add a few comments for readability.