Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: errors in existing cuda_kernels #2877

Merged
merged 3 commits into from
Dec 11, 2023
Merged

fix: errors in existing cuda_kernels #2877

merged 3 commits into from
Dec 11, 2023

Conversation

ManasviGoyal
Copy link
Collaborator

@ManasviGoyal ManasviGoyal commented Dec 8, 2023 •
edited
Loading

Some minor fixes in some of the cuda_kernels.
@ManasviGoyal ManasviGoyal added the gpu Concerns the GPU implementation (backend = "cuda') label Dec 8, 2023
@ManasviGoyal ManasviGoyal marked this pull request as draft December 8, 2023 10:31
@codecov Codecov
Copy link

codecov bot commented Dec 8, 2023 •
edited
Loading

Codecov Report

Merging #2877 (46eee73) into main (9400780) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@ManasviGoyal ManasviGoyal marked this pull request as ready for review December 8, 2023 11:11
@ManasviGoyal ManasviGoyal force-pushed the ManasviGoyal/fix-errors-in-existing-kernels branch from 8724789 to 46eee73 Compare December 8, 2023 11:15
jpivarski
jpivarski approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the division-versus-modulus that you brought up in our last meeting, right?

(And also some kernels to remove. Certainly anything related to "identities" is obsolete.)
@ManasviGoyal
Copy link
Collaborator Author

This is the division-versus-modulus that you brought up in our last meeting, right?

Yes!
ianna
ianna approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ManasviGoyal - excellent! please, squash and merge if you have finished with it. Thanks!
@ManasviGoyal ManasviGoyal merged commit 7687108 into main Dec 11, 2023
38 checks passed
@ManasviGoyal ManasviGoyal deleted the ManasviGoyal/fix-errors-in-existing-kernels branch December 11, 2023 08:12
@ManasviGoyal ManasviGoyal restored the ManasviGoyal/fix-errors-in-existing-kernels branch December 11, 2023 09:04
@ManasviGoyal ManasviGoyal deleted the ManasviGoyal/fix-errors-in-existing-kernels branch December 11, 2023 09:06
ManasviGoyal added a commit that referenced this pull request Dec 11, 2023
@ManasviGoyal
Revert "fix: errors in existing cuda_kernels (#2877)"
85538a8 
This reverts commit 7687108.
@ManasviGoyal ManasviGoyal mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpu Concerns the GPU implementation (backend = "cuda')
3 participants
@ManasviGoyal @ianna @jpivarski