Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: reducer CUDA kernel tests #3162

Merged
merged 37 commits into from
Jun 25, 2024
Merged
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
860868d
feat: add tree reduction implementation of argmin and argmax
ManasviGoyal May 29, 2024
3cdbd7e
feat: add awkward_ListOffsetArray_reduce_local_outoffsets_64 kernel
ManasviGoyal May 30, 2024
c1a846b
test: integration tests for cuda
ManasviGoyal May 30, 2024
7be3f98
test: some more integration tests for cuda
ManasviGoyal May 30, 2024
98fb7ed
feat: add awkward_reduce_count_64 kernel
ManasviGoyal Jun 6, 2024
0ed94ef
fix: indexing and indentation
ManasviGoyal Jun 6, 2024
02c03bc
feat: add awkward_reduce_countnonzero kernel
ManasviGoyal Jun 6, 2024
34fc82b
feat: add reduce sum, min and max kernels
ManasviGoyal Jun 6, 2024
4e00f07
feat: add reduce prod and sum_int_bool
ManasviGoyal Jun 6, 2024
b28a605
feat: add sum_bool and prod_bool kernels
ManasviGoyal Jun 6, 2024
9e7abc7
fix: use cpt.assert_allclose
ManasviGoyal Jun 6, 2024
458165c
test: reducer integration tests
ManasviGoyal Jun 6, 2024
c75cb79
fix: typr conversion
ManasviGoyal Jun 6, 2024
427670c
fix: use atomic to avoid race conditions
ManasviGoyal Jun 7, 2024
127e035
fix: remove unnessary variable
ManasviGoyal Jun 10, 2024
8dee2ae
fix: minor fixes
ManasviGoyal Jun 10, 2024
b957bee
Merge branch 'main' into ManasviGoyal/add-reducer-kernels
ManasviGoyal Jun 11, 2024
896770f
fix: all reducer for atomics
ManasviGoyal Jun 12, 2024
f3d1cdc
fix: missing template
ManasviGoyal Jun 12, 2024
ef47ead
fix: remove complex
ManasviGoyal Jun 12, 2024
c881f1d
fix: atomicMin() for float 32 and indentation
ManasviGoyal Jun 12, 2024
38d30b9
fix: pass correct dtype of identity
ManasviGoyal Jun 12, 2024
51b0e15
fix: remove combinations test
ManasviGoyal Jun 12, 2024
7e7fdc4
fix: manage resources and disable failing test
ianna Jun 13, 2024
1148b95
fix: uncomment fixed test for slicing
ManasviGoyal Jun 18, 2024
8e926ab
fix: correctly interpret typetracer array for cuda backend
ManasviGoyal Jun 18, 2024
38d314d
fix: tests-spec error for bool
ManasviGoyal Jun 18, 2024
15068b6
fix: check for the backend of head
ManasviGoyal Jun 18, 2024
d864481
Merge branch 'main' into ManasviGoyal/add-reducer-kernels
ianna Jun 19, 2024
6cf0919
test: reducer CUDAkernel tests
ManasviGoyal Jun 21, 2024
347c4c9
test: add more reducer tests
ManasviGoyal Jun 21, 2024
bc7e1c0
test: add more reducer tests 2
ManasviGoyal Jun 21, 2024
d34a7b6
Merge branch 'main' into ManasviGoyal/reducer-tests
ianna Jun 21, 2024
b59e428
fix: error for EmptyArray
ManasviGoyal Jun 24, 2024
1cf8e0d
test: generic_reducer_operation and block_boundary
ManasviGoyal Jun 24, 2024
8df6bd4
Update dev/generate-tests.py
ManasviGoyal Jun 24, 2024
71ab593
fix: merge conflit
ManasviGoyal Jun 25, 2024
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: use cpt.assert_allclose
  • Loading branch information
ManasviGoyal committed Jun 6, 2024
commit 9e7abc710864bac255b2e73f79c95c07ccfe2779
6 changes: 4 additions & 2 deletions dev/generate-tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -953,6 +953,7 @@ def gencudakerneltests(specdict):

f.write(
"import cupy\n"
"import cupy.testing as cpt\n"
ManasviGoyal marked this conversation as resolved.
Show resolved Hide resolved
"import pytest\n\n"
"import awkward as ak\n"
"import awkward._connect.cuda as ak_cu\n"
Expand Down Expand Up @@ -1022,7 +1023,7 @@ def gencudakerneltests(specdict):
if isinstance(val, list):
f.write(
" " * 4
+ f"assert cupy.array_equal({arg}[:len(pytest_{arg})], cupy.array(pytest_{arg}))\n"
+ f"cpt.assert_allclose({arg}[:len(pytest_{arg})], cupy.array(pytest_{arg}))\n"
)
else:
f.write(" " * 4 + f"assert {arg} == pytest_{arg}\n")
Expand Down Expand Up @@ -1082,6 +1083,7 @@ def gencudaunittests(specdict):
f.write(
"import re\n"
"import cupy\n"
"import cupy.testing as cpt\n"
"import pytest\n\n"
"import awkward as ak\n"
"import awkward._connect.cuda as ak_cu\n"
Expand Down Expand Up @@ -1218,7 +1220,7 @@ def gencudaunittests(specdict):
if isinstance(val, list):
f.write(
" " * 4
+ f"assert cupy.array_equal({arg}[:len(pytest_{arg})], cupy.array(pytest_{arg}))\n"
+ f"cpt.assert_allclose({arg}[:len(pytest_{arg})], cupy.array(pytest_{arg}))\n"
)
else:
f.write(" " * 4 + f"assert {arg} == pytest_{arg}\n")
Expand Down
Loading