fix: Fix rendering of image subs when using SimpleTextDisplayer (#7258)

This change prevents cues from being created without payload, as is the case with subtitles in image format.
shaka-project · Sep 9, 2024 · cafc7d1 · cafc7d1
1 parent edd0b4b
commit cafc7d1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/text/simple_text_displayer.js b/lib/text/simple_text_displayer.js
@@ -112,7 +112,7 @@ shaka.text.SimpleTextDisplayer = class {
         return false;
       });
 
-      if (!containsCue) {
+      if (!containsCue && inCue.payload) {
         const cue =
             shaka.text.Utils.mapShakaCueToNativeCue(inCue);
         if (cue) {

diff --git a/lib/text/text_utils.js b/lib/text/text_utils.js
@@ -32,6 +32,10 @@ shaka.text.Utils = class {
       }).join('');
     }
 
+    if (!cue.payload) {
+      return cue.payload;
+    }
+
     // Handle bold, italics and underline
     const openStyleTags = [];
     const bold = cue.fontWeight >= shaka.text.Cue.fontWeight.BOLD;