Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Official support for Xbox One #1705

Closed
avelad opened this issue Nov 27, 2018 · 8 comments
Closed

Official support for Xbox One #1705

avelad opened this issue Nov 27, 2018 · 8 comments
Assignees
@joeyparrish
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v3.1

Comments

@avelad
Copy link
Member

avelad commented Nov 27, 2018

I have the player running on the Xbox One. I have seen that things related to the Xbox have been answered in the past(eg: #1395). Are there plans to officially support it?
@TheModMaker
Copy link
Contributor

We actually already have an Xbox One device, we just haven't setup automated testing yet. We have an internal bug to add some kind of test framework to allow us to test it. If anyone has suggestions on how to run automated tests (through Karma) it would be appreciated. But it has been low priority; supposedly it is just the Windows 10 Edge browser, but there are likely subtle platform differences.
@TheModMaker TheModMaker added this to the Backlog milestone Nov 27, 2018
@TheModMaker TheModMaker added the type: enhancement New feature or request label Nov 27, 2018
@chrisfillmore
Copy link
Contributor

We would probably also be interested in this.
@avelad
Copy link
Member Author

avelad commented Feb 22, 2019

@joeyparrish / @TheModMaker , Could the support be added to the README.md although it is not integrated automatically yet?
@joeyparrish
Copy link
Member

We don't actually know that everything is still working on XB1, even though it was at one time. We haven't done any manual test passes on the device in a while, so we can't say we officially support it.

You'll notice that WebOS isn't listed in the README, either, for the same reasons. Even though you've sent us reports about WebOS and contributed code related to WebOS, it's not one of our official platforms yet.
@joeyparrish joeyparrish mentioned this issue Mar 2, 2019
Closed
@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
avelad referenced this issue Feb 11, 2021
@joeyparrish
test: Fix recognition of Xbox One in Karma
f906570 
This updates the UA parser to one that recognizes Xbox devices
including Xbox One.  Corresponds to PR faisalman/ua-parser-js#479

Change-Id: I5e92e78b06c981df1659f73264b6fabfc5eb56ac
@joeyparrish joeyparrish self-assigned this Feb 11, 2021
@joeyparrish
Copy link
Member

Xbox One will soon become an officially-supported platform. If anyone is interested to see how, check out this PR for our new test infrastructure tools for Xbox: shaka-project/generic-webdriver-server#12
@avelad
Copy link
Member Author

avelad commented Mar 22, 2021

@joeyparrish What status is this issue in? Is the Xbox already fully supported? If not, what problems are there?
@joeyparrish
Copy link
Member

Basically, yes. I have a couple of test failures for which fixes are in review as of today, but the failures are only due to poorly-written test expectations. The library is fully working on Xbox One as far as we can tell, and will be tested nightly on Xbox One as soon as these last fixes are merged.
@joeyparrish
Copy link
Member

And by the time I wrote that message, I already had approvals I hadn't seen yet. Thanks, @michellezhuogg, for the code review!

It is now official: We support Xbox One. ����
@joeyparrish joeyparrish modified the milestones: Backlog, v3.1 Apr 12, 2021
joeyparrish added a commit that referenced this issue Apr 22, 2021
@joeyparrish
docs: Official Xbox One support
eebc707 
Closes #1705

Change-Id: I16c2f2dece14dada5e67772c516c6e39de885519
joeyparrish added a commit that referenced this issue Apr 25, 2021
@joeyparrish
docs: Official Xbox One support
a5a3a20 
Closes #1705

Change-Id: I16c2f2dece14dada5e67772c516c6e39de885519
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label May 29, 2021
@shaka-project shaka-project locked and limited conversation to collaborators May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
5 participants
@TheModMaker @joeyparrish @chrisfillmore @avelad @shaka-bot