Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DASH multi period generateVideoKey_ is not stable with close caption #7303

Closed
Iragne opened this issue Sep 13, 2024 · 1 comment · Fixed by #7309 · May be fixed by #7257
Closed

DASH multi period generateVideoKey_ is not stable with close caption #7303

Iragne opened this issue Sep 13, 2024 · 1 comment · Fixed by #7309 · May be fixed by #7257
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@Iragne
Copy link
Contributor

Iragne commented Sep 13, 2024

Have you read the FAQ and checked for duplicate open issues?
Yes

If the problem is related to FairPlay, have you read the tutorial?

No

What version of Shaka Player are you using?

Main and 4.11.2

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from main?
yes

Are you using the demo app or your own custom app?
yes

If custom app, can you reproduce the issue using our demo app?
NA

What browser and OS are you using?
FF

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
NA

What are the manifest and license server URIs?

NA

What configuration are you using? What is the output of player.getConfiguration()?

Default

What did you do?

I have a multi period stream with Close caption (only 1 track for CC)

What did you expect to happen?
I was expecting the if (streams.has(key)) { to find my stream all the time in my multi period stream

What actually happened?

but in fact when debugging i was able to see that the key was not found in streams
My output stream has no CC information. so it's null meaning the key is like that
[false,768,30,"avc","video/mp4",null,[],null,1400000]

But the key in the stream is like that
[false,768,30,"avc","video/mp4",null,[],[],1400000]

look like the outputStream is not with the same structure as the stream, outputStream can be null and stream can be empty array

look the clone stream is not doing it correctly compare to the origin stream

Are you planning send a PR to fix it?

I'm sorry i have no time now to work on it
Sorry guys

@Iragne Iragne added the type: bug Something isn't working correctly label Sep 13, 2024
@avelad avelad added priority: P1 Big impact or workaround impractical; resolve before feature release component: DASH The issue involves the MPEG DASH manifest format labels Sep 13, 2024
@avelad avelad added this to the v4.12 milestone Sep 13, 2024
@avelad avelad added priority: P2 Smaller impact or easy workaround and removed priority: P1 Big impact or workaround impractical; resolve before feature release labels Sep 13, 2024
@Iragne
Copy link
Contributor Author

Iragne commented Sep 13, 2024

now look perfect in my multi period stream thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
2 participants