ci: Allow concurrent lab runs that use different devices #7298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
requested review from
littlespex,
avelad,
JulianDomingo,
theodab and
tykus160
|
Incremental code coverage: No instrumented code was changed. |
avelad
approved these changes
Sep 13, 2024
joeyparrish
added a commit
that referenced
this pull request
Sep 13, 2024
joeyparrish
added a commit
that referenced
this pull request
Sep 13, 2024
joeyparrish
added a commit
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the branch this PR is based on, I was able to start two concurrent lab runs on different sets of browsers:
https://github.com/shaka-project/shaka-player/actions/runs/10836501320
https://github.com/shaka-project/shaka-player/actions/runs/10836507170
The early jobs (Compute SHA, Matrix config, Pre-build Player) were all able to run simultaneously since they only use Actions VMs. The later jobs under the matrix "lab-tests" were also able to run at the same time across workflow runs because they used disjoint sets of browsers.
I started a third run 5 minutes later with some overlap in browsers with the first two runs:
https://github.com/shaka-project/shaka-player/actions/runs/10836571930
Here the ChromeLinux job had to wait for the other ChromeLinux job to complete. Meanwhile, the Safari job was able to proceed.