Allow setting withCredentials in spf xhr options #417
Conversation
|
You're going to have to thread this to |
|
Added commits to forward withCredentials to spf.nav.request.send and spf.nav.load, also added to the markdown file. Let me know if you prefer to have this squashed into one commit. |
| @@ -219,6 +219,8 @@ to the callback will be an object that conforms to the | |||
| [spf.Event](#spf.event)). | |||
| `postData: ArrayBuffer | Blob | Document | FormData | null | string | undefined` | |||
| Optional data to send with the request. Only used if the method is "POST". | |||
| `withCredentials: boolean | undefined` | |||
| Optional flag to configure the XHR to send withCredentials or not. | |||
There was a problem hiding this comment.
You should revert this file; it will be auto-generated from src/api.js with the next release and will use the description from the JsDoc.
|
Please do squash into a single commit. You either do it beforehand in your fork or "squash and merge" using the GitHub UI when merging the PR. |
|
Squashed my commits and addressed comments. Not sure how to mark comments as addressed though. |
|
Ah, sorry I forgot this before -- can you add the |
|
Updated |
| @@ -65,7 +65,8 @@ goog.require('spf.url'); | |||
| * postData: spf.net.xhr.PostData, | |||
| * current: (string|null|undefined), | |||
| * referer: (string|null|undefined), | |||
| * type: (string|undefined) | |||
| * type: (string|undefined), | |||
| * withCredentials: (boolean|undefined) | |||
There was a problem hiding this comment.
Add a corresponding description to the comment above (line ~55).
|
LGTM after nits. |
* forward withCerdentials in spf.nav.request.send * thread through nav.load
|
Addressed comment issue. And updated. |
This allows SPF to be used with CORS + Cookies.