Force header values in the request to be a string. #449
Conversation
This will allow for dynamic header values to be set in the config by simply having an object with a `toString` method.
| @@ -134,7 +134,7 @@ spf.nav.request.send = function(url, opt_options) { | |||
| var value = configHeaders[key]; | |||
| // Treat undefined and null values as equivalent to an empty string. | |||
| // Note that undefined == null. | |||
| headers[key] = (value == null) ? '' : value; | |||
| headers[key] = (value == null) ? '' : String(value); | |||
There was a problem hiding this comment.
Is there a reason not to use value.toString()?
There was a problem hiding this comment.
I could. But this works as well. Any reason to use toString() over String()?
There was a problem hiding this comment.
Whatever the JS equivalent is of the phrase "Pythonic". JSonic 🤔?
I just tend to see methods used rather than constructors.
In any case, not sure how active this project is and whether @nicksay wants to accept updates.
There was a problem hiding this comment.
@nicksay is out until March. I talked to @DavidCPhillips and he seemed OK with the change.
With respect to JSonic - just look to this code base. String(value) happens a couple of times. toString does not appear to be the convention.
There was a problem hiding this comment.
fwiw: (null).toString() -> error. String(null) -> "null". Same for undefined and perhaps other obnoxious things.
This will allow for dynamic header values to be set in the config by
simply having an object with a
toStringmethod.