Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstancedMesh: Add initial value to setColorAt() method. #28854

Merged
merged 2 commits into from
Jul 13, 2024
Merged

InstancedMesh: Add initial value to setColorAt() method. #28854

merged 2 commits into from
Jul 13, 2024

Conversation

lanvada
Copy link
Contributor

@lanvada lanvada commented Jul 12, 2024 •
edited by Mugen87
Loading

Fixed #28853.

Add an initial value to the setColorAt() method of InstancedMesh so that other instances that have not set a color will not turn black
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
683.5 kB (169.2 kB) 683.5 kB (169.2 kB) +8 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
460.7 kB (111.1 kB) 460.7 kB (111.1 kB) +0 B
@Mugen87 Mugen87 added this to the r167 milestone Jul 12, 2024
@Mugen87 Mugen87 merged commit f0273bb into mrdoob:dev Jul 13, 2024
12 checks passed
@Mugen87 Mugen87 changed the title Add initial value to InstancedMesh's setColorAt method Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@lanvada @Mugen87 @zehuahu