Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InstancedMesh: Add initial value to setColorAt() method. #28854

Merged
merged 2 commits into from
Jul 13, 2024
Merged

InstancedMesh: Add initial value to setColorAt() method. #28854

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ce0ab5
Add initial value to InstancedMesh's setColorAt method
zehuahu Jul 12, 2024
ef53147
add spaces
zehuahu Jul 12, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add initial value to InstancedMesh's setColorAt method
  • Loading branch information
@zehuahu
zehuahu committed Jul 12, 2024
commit 8ce0ab5f2ecbac3f686a18096d6de426f88f11ba
2 changes: 1 addition & 1 deletion src/objects/InstancedMesh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@

if ( this.instanceColor === null ) {

this.instanceColor = new InstancedBufferAttribute( new Float32Array( this.instanceMatrix.count * 3 ), 3 );
this.instanceColor = new InstancedBufferAttribute( new Float32Array( this.instanceMatrix.count * 3 ).fill(1), 3 );

Check failure on line 210 in src/objects/InstancedMesh.js

View workflow job for this annotation

GitHub Actions / Lint testing 

There must be a space after this paren

Check failure on line 210 in src/objects/InstancedMesh.js

View workflow job for this annotation

GitHub Actions / Lint testing 

There must be a space before this paren

}

Expand Down
Loading