WebGPURenderer: New normal nodes approach #29137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Aug 14, 2024
| @@ -40,7 +39,6 @@ class NodeMaterial extends Material { | |||
|
|
|||
| this.fog = true; | |||
| this.lights = false; | |||
| this.normals = true; | |||
There was a problem hiding this comment.
Glad to see normals is gone! 🎉
Merged
0b5vr
added a commit
to pixiv/three-vrm
that referenced
this pull request
Aug 19, 2024
Starting from r168, `setupNormal` returns the normal node instead of assigning inside the `NodeMaterial.setupNormal` See: mrdoob/three.js#29137
This was referenced Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Closes #28939, #29121
Description
Thanks to the once deferred function we can use constants as functions that will be executed at compile time. This approach is superior to the current ones that use
transformedNormalView.assign()and I think we can use it not so soon inpositionLocalandpositionPreviousas well.