Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: New normal nodes approach #29137

Merged
merged 10 commits into from
Aug 14, 2024
Prev Previous commit
cleanup
  • Loading branch information
sunag committed Aug 14, 2024
commit 4ba84e0416288a402f96567a78f932b59bb0d69a
2 changes: 1 addition & 1 deletion src/nodes/accessors/MorphNode.js
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ class MorphNode extends Node {
const { geometry } = builder;

const hasMorphPosition = geometry.morphAttributes.position !== undefined;
const hasMorphNormals = builder.geometry.hasAttribute( 'normal' ) && geometry.morphAttributes.normal !== undefined;
const hasMorphNormals = geometry.hasAttribute( 'normal' ) && geometry.morphAttributes.normal !== undefined;

const morphAttribute = geometry.morphAttributes.position || geometry.morphAttributes.normal || geometry.morphAttributes.color;
const morphTargetsCount = ( morphAttribute !== undefined ) ? morphAttribute.length : 0;
Expand Down